Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

illegal values in <objectDesc> "form" attribute cause errors in editor #311

Closed
paregorios opened this issue Aug 8, 2017 · 6 comments
Closed

Comments

@paregorios
Copy link
Member

Some characters are prohibited from use in attribute values, but some illegal characters (e.g., "?") have been written into the "form" attribute on the <objectDesc> element in XML converted from LDAB (e.g., "roll?").

Files like this are invalid XML and shouldn't have been committed to the repository master branch without a successful attempt to validate them.

A user at the NYC workshop undertook to input a text for a DCLP stub file from LDAB that had this problem. He typed in the text and clicked "save." The editor reported an "XML Error" indicating an invalid value for the form attribute. Attempting to navigate back or to "save the broken Leiden plus" (which wasn't broken), resulted in everybody's favorite "we're sorry something went wrong" message.

@paregorios
Copy link
Member Author

@jcowey @rla2118 please advise to whom this should be assigned for fixing

@jcowey
Copy link
Contributor

jcowey commented Aug 8, 2017

yes this is bad news - shall have this chased up tomorrow

@jcowey
Copy link
Contributor

jcowey commented Aug 8, 2017

which file was the one affected, so that it can be made available again?

@paregorios
Copy link
Member Author

paregorios commented Aug 8, 2017 via email

@Edelweiss
Copy link

Edelweiss commented Aug 9, 2017

Validator versions:

SoSOL
http://www.stoa.org/epidoc/schema/8.22/tei-epidoc.rng

in eXist
/db/data/epidoc/schema/latest/tei-epidoc.rng

some idp.data DCLP EpiDoc xml files have
8.13 (https://github.com/DCLP/idp.data/blame/master/DCLP/66/65429.xml)

@Edelweiss Edelweiss self-assigned this Aug 9, 2017
@Edelweiss
Copy link

Edelweiss commented Aug 9, 2017

Found one example for form="roll?", valid for schema = 8.22 or latest

https://github.com/DCLP/idp.data/blob/master/DCLP/62/61362.xml#L34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants