fix: adds missing column names

DCMLab · Nov 25, 2023 · 4252ad9 · 4252ad9
1 parent 8f74b10
commit 4252ad9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/src/dimcat/data/resources/features.py b/src/dimcat/data/resources/features.py
@@ -114,8 +114,10 @@ class DcmlAnnotations(Annotations):
         "chord_type",
         "figbass",
         "form",
+        "globalkey",
         "globalkey_is_minor",
         "globalkey_mode",
+        "localkey",
         "localkey_and_mode",
         "localkey_is_minor",
         "localkey_mode",

diff --git a/src/dimcat/steps/analyzers/counters.py b/src/dimcat/steps/analyzers/counters.py
@@ -38,7 +38,7 @@ def groupby_apply(self, feature: Feature, groupby: SomeSeries = None, **kwargs):
         if groupby is None:
             groupby = feature.get_grouping_levels(self.smallest_unit)
             self.logger.debug(
-                f"Using the {feature.resource_name}'s default groupby {groupby!r}"
+                f"Using the {feature.resource_name}'s grouping levels {groupby!r}"
             )
         groupby.append(feature.value_column)
         if (

diff --git a/src/dimcat/steps/base.py b/src/dimcat/steps/base.py
@@ -426,6 +426,7 @@ def _make_new_resource(self, resource: Feature) -> Feature:
         # new_resource = result_constructor.from_dataframe(
         #     df=result_df,
         #     resource_name=result_name,
+        #     **resource_kwargs
         # )
         # print(f"NEW RESOURCE STATUS: {new_resource.status}")
         self.logger.debug(