Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Staging into Production, 2023-Sept-07 edition #1027

Merged
merged 26 commits into from Sep 14, 2023
Merged

Conversation

jacobdgm
Copy link
Contributor

@jacobdgm jacobdgm commented Sep 7, 2023

New code is running on the staging server!

Pages that have been changed:

  • All pages, header: Short Video Intro now opens in a new tab
  • Admin: Chant List - now allows searching/filtering by id
  • Admin: Sequence List - now allows searching/filtering by id
  • Chant Create: fixed bug where Suggested Fulltext buttons sometimes wouldn't work
  • Chant Edit: in the main body of the page, when not editing a specific chant, we now have a link pointing to the Chant Create page.
  • Chant Detail: We now display the differentia_new ("Differentiae Database") field
  • Chant Proofread: in the main body of the page, when not editing a specific chant, we now have links pointing to the Chant Create and Source Create pages.
  • Chant/Sequence Create/Edit pages: it is now impossible to create a chant or sequence without a source (existing chants/sequences without a source have been assigned to an unpublished dummy "Unknown Source" source). (Jacob notes that it's difficult to test this on these pages themselves, since they've got the source ID in the URL. But I'm indeed unable to create sourceless chants/sequences in the Admin area, so we're good)

lucasmarchd01 and others added 26 commits August 21, 2023 16:07
Allow search by id for chant/sequence in admin area
Remove unnecessary print statements in views/redirect_documents
with link to differentiaedatabase.ca
Chant Detail: Add Differentia DB field
Ensure Short Video Introduction opens in new tab
to fix bug occurring when Cantus ID includes a '.'
Insert "add chant" links to chant-proofread and chant-edit pages
Make migrations to remove null=True and blank=True in source ForeignKey
Chant Create: fix bug in chant suggestions
Merge develop into staging, 2023-Sept-07 edition
@annamorphism
Copy link

"now allows searching/filtering by id" ---this is CantusID, correct?

@annamorphism
Copy link

"we now display a link in the sidebar pointing to the Chant Create page"--there's "add new chant" in the body of a source's edit-chants page, is that what you mean?

@annamorphism
Copy link

I'm a wee bit confused about the chants in Unknown Source. For example http://206.12.88.113/chant/688446 seems to include itself in its concordances, with a siglum (presumably the one connected to that chant when it was made). But clicking on this siglum takes you back to the chant page and not a source (I'm thinking this maybe shouldn't be linked?). Meanwhile I can't tell if the other chants from Unknown Source show up as their own concordances--I think they don't. Which is fine, since they're anomalous, I'm just unsure what the intended behaviour is here.

@jacobdgm
Copy link
Contributor Author

jacobdgm commented Sep 8, 2023

"now allows searching/filtering by id" ---this is CantusID, correct?

no - if you know the ID (i.e. primary key) of the chant, you can enter it and that specific chant will come up.

@jacobdgm
Copy link
Contributor Author

jacobdgm commented Sep 8, 2023

"we now display a link in the sidebar pointing to the Chant Create page"--there's "add new chant" in the body of a source's edit-chants page, is that what you mean?

Oops, you're right. I'll edit my initial comment.

@annamorphism
Copy link

"now allows searching/filtering by id" ---this is CantusID, correct?

no - if you know the ID (i.e. primary key) of the chant, you can enter it and that specific chant will come up.
oops, realized that my tooling around on admin was still only on production (not sure I can access this on staging?).

@jacobdgm jacobdgm marked this pull request as ready for review September 8, 2023 19:41
@jacobdgm
Copy link
Contributor Author

everything looks good! I'll merge this tomorrow and update the production server. If anyone wants to approve this before merging, that might be best practice ^^

@jacobdgm jacobdgm merged commit 75ea8b1 into production Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants