Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Staging into Production, 2023-06-16 edition #752

Merged
merged 126 commits into from Jun 20, 2023
Merged

Conversation

jacobdgm
Copy link
Contributor

@jacobdgm jacobdgm commented Jun 16, 2023

Once we finish testing this and merge it into Production, we should be ready for the soft launch!

Known issue: #747 might otherwise prevent us from merging this, but this is not visible to anonymous users, and it's in line to be fixed when we next merge develop into staging, so we'll overlook it for now.

Pages that have been changed:

  • General (no associated pages):
    • Django Debug Toolbar has been set up to be available whenever DEBUG is set to True (this should not be visible on Staging or eventually Production)
    • wrote tests and updated tests
    • dummy users (i.e. Indexers from OldCantus) now have unusable passwords
    • when we create new users from list of users on OldCantus, we now give them a long random password, and give them a full_name
  • base.html (i.e. all pages)
    • previous "Reset password" link now reads "Change password"
    • "Admin Navigation" area in footer is now shown only to contributors, editors and project managers, rather than to all users
  • Article List:
    • decrease the number of articles displayed per page from 100 to 10
    • a preview of each article (in most cases, the entire article) is shown on the article list page
    • /news (à la OldCantus) now redirects to /articles
  • Century Detail:
    • displayed sources have title attributes
  • Chant Create:
    • Office and Genre dropdown selectors now include only the short form of the office/genre, and not the full name
    • "Addendum" field now formatted to match other similar fields
  • Chant Detail:
    • fix bug where page wouldn't load if saved volpiano consisted of just a \n character (6804e10)
    • wide tables no longer have overlapping text, and have a horizontal scroll bar when necessary
  • Chant Edit:
    • Office and Genre dropdown selectors now include only the short form of the office/genre, and not the full name
    • fix bug where page wouldn't load if saved volpiano consisted of just a \n character (6804e10)
    • "Addendum" field now formatted to match other similar fields
  • Chant List:
    • If there are 0 results, the table of results is now hidden, and a "no chants found" message is displayed
  • Chant Search
    • table no longer has overlapping text, and has a horizontal scroll bar when necessary
  • CSV Export (available from Source Detail page):
    • users can now download CSVs for unpublished sources, so long as they are logged in (previously, they couldn't be downloaded at all if the source was not published)
    • Changed the path to this view from csv/<str:source_id>.csv to source/<str:source_id>/csv/
    • On OldCantus, this view lived at the path sites/default/files/csv/<str:source_id>.csv. We have a view set up to redirect from this URL pattern to the new path
  • Feast Detail:
    • Formatting of "Notes" improved
    • list of chants/sources related to the feast are now fully hidden (headers are not displayed) when the lists of chants/sources contain no items
  • Indexer Detail:
    • when a user tries to visit a /indexer/<id> page, they're redirected to the proper user page
  • Login
    • now has a <title> tag, so the name of the page is now properly displayed on the tab at the top of the browser
    • add link to reset password
  • Node URLs:
    • When a user visits a /node/ url that was valid in OldCantus, they will now be taken to the proper detail page
  • Notation Detail:
    • title attributes have been added to source detail links
  • Password Reset pages:
    • Password reset has been set up - users can request an email containing a link to reset their password.
  • Provenance Detail:
    • we now hide unpublished sources for anonymous users (edit: this fix didn't work; a proper fix is ready to be merged into staging...)
    • displayed sources now also have a title attribute
  • Sequence List
    • if there are 0 results, the table of results is now hidden, and a "no sequences found" message is displayed
  • Source Detail:
    • when you click on "CSV export", it now automatically downloads the file rather than rendering it in the browser, and the suggested filename is <source.id>.csv
    • links to chant edit and chant proofread pages are no longer displayed if source has 0 chants
  • Source List:
    • if there are 0 results, the table of results is now hidden, and a "no sources found" message is displayed
  • User Source List
    • links to chant edit and chant proofread pages for specific sources are no longer displayed if source has 0 chants

Jacob has tested all of these pages on Safari, and has identified only one bug - the persistent one on the provenance detail page.

Changes since Jacob finished testing the pages above:

  • flatpages/default.html (used for rendering flat pages, i.e. homepage, etc.)
    • there's now a "Sources created by user" card in the right sidebar
    • in sidebars on this page, "edit chants" links no longer appear for sources that contain no chants
  • Chant edit page
    • if source contains no chants, the page now loads successfully
  • Indexer detail page
    • if user enters an invalid ID number, they'll be shown our custom 404 page rather than a blank page
  • Node redirect page
    • if user enters an invalid ID number, they'll be shown our custom 404 page rather than a blank page
  • Proofread Chant page
    • if source contains no chants, the page now loads successfully
  • Provenance detail page
    • unpublished sources are not shown to non-logged-in users
  • Source List page
    • table now includes a horizontal scroll bar when the window gets narrow

lucasmarchd01 and others added 30 commits June 1, 2023 19:07
Notation detail page: add title attribute to all sources, displaying the sources' sigla
Improve layout/etc. of Feast Detail page
instead of opening csv file in new tab

also, specify default filename to match OldCantus
Bring CSV export view into alignment with OldCantus
Chant List page: prevent table from displaying when there are no results
Improved Dropdown Menu Display for Genre and Office
@jacobdgm
Copy link
Contributor Author

Relevant to the timeline for getting this merged: due to changes in McGill's network configuration, we don't have access to the staging and production servers for the moment. @kqct is working on this, and we're hoping we can get this resolved very soon, but for the time being, we can't make any updates to the staging and production VMs.

pythonsemicolon and others added 18 commits June 19, 2023 10:29
View functions now raise an Http404 instead of returning an HttpResponsenotFound, resulting in a traceback when running loclaly, as expected.
Display correct 404 page for /node/ and /indexer/ redirects
…es to be displayed

...even when user is not authenticated
Fix bug in provenance_detail.html
Hide edit chants link from "my sources" sidebar on flatpages
Fix 404 error on edit-chants page for sources with no chants and deleting last chant in source
Add side scrolling to source list table
merge develop into staging - 2023-06-20 edition
@jacobdgm jacobdgm merged commit ad368d5 into production Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants