New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Staging into Production, 2023-06-16 edition #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the sources' sigla
Notation detail page: add title attribute to all sources, displaying the sources' sigla
Improve layout/etc. of Feast Detail page
…s used in OldCantus
instead of opening csv file in new tab also, specify default filename to match OldCantus
Bring CSV export view into alignment with OldCantus
Chant List page: prevent table from displaying when there are no results
Improved Dropdown Menu Display for Genre and Office
to match OldCantus
…tusDB into source-sidebar
Add "Sources created by user" list to homepage
Relevant to the timeline for getting this merged: due to changes in McGill's network configuration, we don't have access to the staging and production servers for the moment. @kqct is working on this, and we're hoping we can get this resolved very soon, but for the time being, we can't make any updates to the staging and production VMs. |
View functions now raise an Http404 instead of returning an HttpResponsenotFound, resulting in a traceback when running loclaly, as expected.
Display correct 404 page for /node/ and /indexer/ redirects
…es to be displayed ...even when user is not authenticated
Fix bug in provenance_detail.html
Hide edit chants link from "my sources" sidebar on flatpages
Fix 404 error on edit-chants page for sources with no chants and deleting last chant in source
Add side scrolling to source list table
merge develop into staging - 2023-06-20 edition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once we finish testing this and merge it into Production, we should be ready for the soft launch!
Known issue: #747 might otherwise prevent us from merging this, but this is not visible to anonymous users, and it's in line to be fixed when we next merge develop into staging, so we'll overlook it for now.
Pages that have been changed:
DEBUG
is set toTrue
(this should not be visible on Staging or eventually Production)full_name
/news
(à la OldCantus) now redirects to/articles
\n
character (6804e10)\n
character (6804e10)csv/<str:source_id>.csv
tosource/<str:source_id>/csv/
sites/default/files/csv/<str:source_id>.csv
. We have a view set up to redirect from this URL pattern to the new path/indexer/<id>
page, they're redirected to the proper user page<title>
tag, so the name of the page is now properly displayed on the tab at the top of the browser/node/
url that was valid in OldCantus, they will now be taken to the proper detail page<source.id>.csv
Jacob has tested all of these pages on Safari, and has identified only one bug - the persistent one on the provenance detail page.
Changes since Jacob finished testing the pages above: