Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Staging into Production, 2023 july 11 edition #831

Merged
merged 136 commits into from Jul 18, 2023
Merged

Conversation

jacobdgm
Copy link
Contributor

@jacobdgm jacobdgm commented Jul 11, 2023

We have a bunch of fixes and improvements on staging! Once we test them, we should put them on Production!

For changes to formatting, I've included checkboxes for chrome, firefox and safari to ensure things display properly. Otherwise, for changes to the data displayed etc., we probably only need to check using a single browser. You're welcome to participate in checking these, @lucasmarchd01, @dchiller, @JoyfulGen and @annamorphism - Check them off as you visit/inspect them!

List of places where we expect things to be changed/updated:

  • General
    • When a user creates a source, they are automatically added as an editor for that source
    • fixed a bug in the search bar displayed at the top of every page, where out-of-date results would continue to be displayed if the user backspaced several times to clear the search box
  • Flat pages template (homepage, etc.)
    • When displaying sources in the sidebar, we now use the source's siglum rather than its less-informative rism_siglum
    • "my sources" sidebar displayed while user is logged in
      • list of sources is now paginated
  • Admin area
    • Source List
      • there's now a search box at the top of the page allowing the user to search for specific sources
    • User Edit
      • where source-user relationships are added, there's now a box to allow the user to enter the ID of a source to select it
  • Article Detail page
    • now includes a "What's New" card in the sidebar that displays the five most recent articles
  • Article List page
    • now includes a "What's New" card in the sidebar that displays the five most recent articles
  • Chant Detail page
    • slight refactor in template, should make the page load faster
  • Chant List page
    • now, only sources from the Cantus Segment appear in the dropdown where you can select a source (i.e. sources from the Bower segment no longer appear)
    • if a user tries to access the Chant List page, and specify a source not in the Cantus segment, they are shown a 404 error
  • Chant Search page
    • results are now ordered by their source's siglum by default
    • if a user arrived at the page via the general search bar and clicked on a column header to change the ordering, the search term in the search bar would disappear and no results would be displayed. Clicking on the headers now works, and doesn't cause the term in the search bar to disappear.
    • "search bar" searches while user is logged in now return unpublished sources as well as published ones. (previously, only published sources would be returned, whether or not the user was logged in)
    • "search bar" searches now search all text fields, and not just the MS spelling field
    • if no chants are found matching the query, a "No chants found" message is now displayed
    • formatting of the search fields at the top of the page has been improved
  • Chant Search Manuscript page
    • formatting of the search fields at the top of the page has been improved
  • Feast List page
    • if no feasts are found matching the query, a "No feasts found" message is now displayed
  • Search Manuscript page
    • the path for this view has been updated from /chant-search-ms/<source ID> to /searchms/<source ID>, to match OldCantus
  • Source Create page
    • When a new source is created, we now redirect to the source detail page.
  • Source Detail page
    • In the table of sequences we display when the source contains sequences, we now display three columns of "Notes".
      • the text in this table is also smaller, making it appear less cramped.
        • chrome
        • firefox
        • safari
      • capitalization in the table header ("Text Incipit") has also been corrected/improved, and title (mouseover) attributes have been added to all of the column headers.
      • the table is now table-responsive, so when the window is small, it supports horizontal scrolling
        • chrome
        • firefox
        • safari
    • if user is logged in, we now display "Source Status" below "Full Source/Fragment"
    • slight refactor in template, should make the page load faster
  • Source Edit page
    • jump-to-folio and jump-to-feast selectors now work
    • navigation links are now displayed in the sidebar
    • the page now inherits from SourceDetailView. I gather this has something to do with get_context_data. @lucasmarchd01, can you clarify why this was done?
    • slight refactor in template, should make the page load faster
  • Source List page
    • slight refactor in template, should make the page load faster
  • Login
    • we used to show a message telling users to change their password if they hadn't yet changed it since we last did a data sync from OldCantus to NewCantus. Since newly created users are now given random passwords, we have removed the login view, redirecting instead to the homepage, and no longer display this message.
  • Melody search page
  • User Detail page
    • If a user does not have a full_name set, we display a placeholder value in the main heading instead of "None"
    • prevent not-logged-in people from viewing/visiting user detail pages of Users who are not Indexers (they should now get a 401 error)
  • User Source List page ("My Sources")
    • we no longer display links to proofread the listed sources, unless the user actually has sufficient permissions to proofread sources.
    • in "Sources Created by user" in sidebar, we now display only the sources the user created, and not all the sources for which the user is a "current editor"
    • In the "Sources Created by user" sidebar, we paginate by 6 now instead of by 10
  • json_cid API
    • this API is now available at /json-cid/<cantus ID>
  • json_melody_export API
    • refactored
  • json_node_export API
    • refactored
    • API now returns 404 for ids > 1_000_000
  • json_sources_export API
    • refactored

lucasmarchd01 and others added 30 commits June 20, 2023 13:43
Add search options for source-user relationship in admin area
fix typo: "intentional chant" -> "intentional change"
…ences within source

and update formatting, wrapping sequences table in <small> tags
User detail page: display placeholder value when user doesn't have a full_name set
Source Detail page: add notes1-3 columns when displaying list of sequences within source
Chant Search page via search bar: Ensure default ordering is by siglum, and preserve search term
change url path from /chant-search-ms/ to /searchms/
lucasmarchd01 and others added 29 commits July 13, 2023 14:36
Redirect user to Source Detail page after they create a source
Update JSON Node Export API to raise 404 for items created in NewCantus
Improve layout of Chant Search, Chant Search MS views
my-sources: fix bug in user created sources side panel
fix update_source_melody_count signal
Write Tests for Chant Search View
Merge develop into staging, 2023 July 18 edition
@jacobdgm jacobdgm merged commit 6bd78df into production Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants