New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Staging into Production, 2023 july 11 edition #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add search options for source-user relationship in admin area
fix typo: "intentional chant" -> "intentional change"
…ences within source and update formatting, wrapping sequences table in <small> tags
…g from search bar
…en column headers clicked on
User detail page: display placeholder value when user doesn't have a full_name set
Source Detail page: add notes1-3 columns when displaying list of sequences within source
Chant Search page via search bar: Ensure default ordering is by siglum, and preserve search term
…n source selector
change url path from /chant-search-ms/ to /searchms/
Redirect user to Source Detail page after they create a source
Update JSON Node Export API to raise 404 for items created in NewCantus
Improve layout of Chant Search, Chant Search MS views
my-sources: fix bug in user created sources side panel
fix update_source_melody_count signal
Write Tests for Chant Search View
Merge develop into staging, 2023 July 18 edition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a bunch of fixes and improvements on staging! Once we test them, we should put them on Production!
For changes to formatting, I've included checkboxes for chrome, firefox and safari to ensure things display properly. Otherwise, for changes to the data displayed etc., we probably only need to check using a single browser. You're welcome to participate in checking these, @lucasmarchd01, @dchiller, @JoyfulGen and @annamorphism - Check them off as you visit/inspect them!
List of places where we expect things to be changed/updated:
siglum
rather than its less-informativerism_siglum
/chant-search-ms/<source ID>
to/searchms/<source ID>
, to match OldCantustable-responsive
, so when the window is small, it supports horizontal scrolling/json-cid/<cantus ID>
id
s > 1_000_000