OMR Search: Add class for creating ngrams of information extracted from MEI #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchiller
force-pushed
the
omr-search
branch
2 times, most recently
from
a93b3ec
to
f4dfe11
Compare
ahankinson
reviewed
Mar 26, 2024
dchiller
changed the title
jacobdgm
requested changes
Mar 26, 2024
app/public/cantusdata/helpers/mei_processing/bounding_box_utils.py
Outdated
Show resolved
Hide resolved
app/public/cantusdata/helpers/mei_processing/bounding_box_utils.py
Outdated
Show resolved
Hide resolved
app/public/cantusdata/test/core/helpers/mei_processing/test_bounding_box_utils.py
Outdated
Show resolved
Hide resolved
app/public/cantusdata/test/core/helpers/mei_processing/test_mei_parser.py
Outdated
Show resolved
Hide resolved
app/public/cantusdata/test/core/helpers/mei_processing/test_mei_tokenizer.py
Show resolved
Hide resolved
Add comments on bounding box structure
jacobdgm
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
MEIParserclass rewritten in Update MEI Parser #806 to createMEITokenizerwhich divides content parsed from the MEI file into documents that can be indexed in solrlxmlfor MEI (xml) parsingMEIParserand testsThis concludes (hopefully) a re-writing of tools (along with #806 and #833) needed for MEI parsing.