Update MEI Parser #806
Merged
Update MEI Parser #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add dev poetry Add test for new MEI parser Add new MEI parser Remove poetry files from branch
jacobdgm
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
On the whole, looks very good!
I left a couple of comments along the lines of "check to make sure this works as expected" and a handful of comments for optional fixes (mostly suggesting that all the variables be type-annotated). Happy to approve this, and trust you to go through and make any tweaks that are necessary.
app/public/cantusdata/test/core/helpers/mei_processing/test_mei_parser.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helperssubfolder tomei_processingfrommei_conversion(keeps all contents for the time being)A step on the way to implementing OMR search!