Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate Nightly Grype scan failure #31

Merged
merged 5 commits into from
Jan 12, 2022
Merged

Investigate Nightly Grype scan failure #31

merged 5 commits into from
Jan 12, 2022

Conversation

markysoft
Copy link
Contributor

@markysoft markysoft commented Jan 12, 2022 •
edited

Description

Nightly scan is failing with error messages, PR to reproduce and fix.

Checklist:

  • I have ensured the Defra version in the JOB.env file matches that in the Dockerfile
  • I have ensured the Node.js versions in the image-matrix.json match the Dockerfile and the table in the README.md
  • I have added newly ignored vulnerabilities to the POLICY_CONFIGURATION.md
  • I have checked if previously identified vulnerabilities have been patched, and can be removed from the .grype.yaml and POLICY_CONFIGURATION.md files

paulsimonandrews
paulsimonandrews approved these changes Jan 12, 2022
View reviewed changes
Copy link
Collaborator

@paulsimonandrews paulsimonandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markysoft markysoft merged commit 32c26e1 into master Jan 12, 2022
@markysoft markysoft deleted the investigate-nightly-failure branch January 12, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulsimonandrews paulsimonandrews paulsimonandrews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@markysoft @paulsimonandrews