Add end to end test coverage and main entry point for bucket #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irisfaraway
reviewed
Jun 6, 2019
cintamani
changed the title
Add the end-to-end feature test and document the Gem's configuration and usage. Add main entry point to the buckets and move AWS methods in the correct module
cintamani
force-pushed
the
add-end-to-end-test-coverage
branch
from
94b8b9d
to
bc70ebe
Compare
cintamani
commented
Jun 7, 2019
Co-Authored-By: Iris Faraway <iris.faraway@gmail.com>
Cruikshanks
approved these changes
Jun 7, 2019
There was a problem hiding this comment.
LGTM, though as @irisfaraway had a first pass at this might just want to check in with her before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #3
Add the end-to-end feature test and document the Gem's configuration and usage.