Incorrect details on Welsh payment screen #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…narCloud suggestion)
jaucourt
requested changes
Jun 3, 2024
Create tests for 12m, 8d and 1d using symbols
…lsh-payment-screen
Extracting the description as Symbol values are unique and cannot be directly compared to strings
jaucourt
requested changes
Jun 26, 2024
packages/gafl-webapp-service/src/processors/__tests__/licence-type-display.spec.js
Show resolved
Hide resolved
It is good practice to ensure tests are as small as possible, with only one expect statement per test. This aids with ease of debugging in the future
|
jaucourt
approved these changes
Jun 27, 2024
jaucourt
deleted the
feature/iwtf-3981-incorrect-details-on-welsh-payment-screen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/IWTF-3981
In the Welsh user journey, GOV.UK PAY defaults correctly to Welsh, pulling through the details of purchase from the main service. However, in at least one instance, we are supplying the licence length in English – see attached image. In the grey box, it says "Brithyllod a physgod bras, hyd at 2 wialen, 1 day" instead of "1 diwrnod".
This ticket is to ensure that details are correctly supplied in Welsh for all licence types.