Renewal start page and user permissions #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
irisfaraway
force-pushed
the
feature/start-page-user-permissions
branch
2 times, most recently
from
4d4e438
to
afcd139
Compare
https://eaflood.atlassian.net/browse/WC-89 Before users begin the renewal process, we should set their expections for how long the renewal lasts and what it will cost. We should also make sure they actually have permission to renew the registration - users should not be able to modify registrations which don't belong to them.
Any requests where a user's email doesn't match the account_email for a registration are redirected to an error page. I also switched to the custom error pages for invalid reg_identifiers. This resulted in a lot of test updates.
irisfaraway
force-pushed
the
feature/start-page-user-permissions
branch
from
2fb7537
to
c5ea7d6
Compare
!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WC-89
Before users begin the renewal process, we should set their expectations for how long the renewal lasts and what it will cost.
We should also make sure they actually have permission to renew the registration – users should not be able to modify registrations which don't belong to them. I've implemented CanCanCan to handle this, which might be overkill for now but will come in handy once we have to handle admin users as well.
This PR also adds some custom error pages as there were several instances where it didn't make sense to display the errors on the page (as with validations).