Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renewal start page and user permissions #11

Merged
merged 12 commits into from
Dec 20, 2017
Merged

Renewal start page and user permissions #11

merged 12 commits into from
Dec 20, 2017

Commits on Dec 20, 2017

  1. Renewal start page and user permissions 

    https://eaflood.atlassian.net/browse/WC-89

Before users begin the renewal process, we should set their expections for how long the renewal lasts and what it will cost.

We should also make sure they actually have permission to renew the registration - users should not be able to modify registrations which don't belong to them.
    @irisfaraway
    irisfaraway committed Dec 20, 2017
    Configuration menu
    Copy the full SHA
    bb8db1f View commit details
    Browse the repository at this point in the history

  2. Add draft copy to renewal start page

    @irisfaraway
    irisfaraway committed Dec 20, 2017
    Configuration menu
    Copy the full SHA
    c84086e View commit details
    Browse the repository at this point in the history

  3. Update service description

    @irisfaraway
    irisfaraway committed Dec 20, 2017
    Configuration menu
    Copy the full SHA
    822e626 View commit details
    Browse the repository at this point in the history

  4. Set fees and expiry date separately

    @irisfaraway
    irisfaraway committed Dec 20, 2017
    Configuration menu
    Copy the full SHA
    bcf3eca View commit details
    Browse the repository at this point in the history

  5. DRY renewal date calculations

    @irisfaraway
    irisfaraway committed Dec 20, 2017
    Configuration menu
    Copy the full SHA
    4bf980e View commit details
    Browse the repository at this point in the history

  6. Copy registration data to transient object after initializing

    @irisfaraway
    irisfaraway committed Dec 20, 2017
    Configuration menu
    Copy the full SHA
    510ac14 View commit details
    Browse the repository at this point in the history

  7. Add tests for different users

    @irisfaraway
    irisfaraway committed Dec 20, 2017
    Configuration menu
    Copy the full SHA
    f0c1cee View commit details
    Browse the repository at this point in the history

  8. Install CanCanCan

    @irisfaraway
    irisfaraway committed Dec 20, 2017
    Configuration menu
    Copy the full SHA
    563457a View commit details
    Browse the repository at this point in the history

  9. Downgrade CanCanCan to Mongoid-compatible version

    @irisfaraway
    irisfaraway committed Dec 20, 2017
    Configuration menu
    Copy the full SHA
    64555a2 View commit details
    Browse the repository at this point in the history

  10. Block users from renewing registrations which aren't theirs 

    Any requests where a user's email doesn't match the account_email for a registration are redirected to an error page.

I also switched to the custom error pages for invalid reg_identifiers.

This resulted in a lot of test updates.
    @irisfaraway
    irisfaraway committed Dec 20, 2017
    Configuration menu
    Copy the full SHA
    23100a6 View commit details
    Browse the repository at this point in the history

  11. RenewalStartFormController is no longer special

    @irisfaraway
    irisfaraway committed Dec 20, 2017
    Configuration menu
    Copy the full SHA
    ecd0bbc View commit details
    Browse the repository at this point in the history

  12. Tidy up FormsController

    @irisfaraway
    irisfaraway committed Dec 20, 2017
    Configuration menu
    Copy the full SHA
    c5ea7d6 View commit details
    Browse the repository at this point in the history