Enable active_registration for an OrderItemLog
#1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/RUBY-1787 - Before exporting a copy card item, we need to check that the registration is active - Here we mixin the CanCheckRegistrationStatus concern and declare that an OrderItemLog belongs_to a Registration - And we update the existing specs to ensure that the Registration is persisted before it is assigned to the OrderItemLog
tobyprivett
changed the title
PaulDoyle-DEFRA
previously approved these changes
Mar 2, 2022
tobyprivett
force-pushed
the
feature/order-item-log-registration-status
branch
from
670f8b6
to
01d384d
Compare
| @@ -6,6 +6,7 @@ | |||
| module WasteCarriersEngine | |||
| class OrderItemLog | |||
| include Mongoid::Document | |||
| include CanCheckRegistrationStatus | |||
There was a problem hiding this comment.
Can this be dropped now that active_registration? has been added?
There was a problem hiding this comment.
Yes. Removing...
PaulDoyle-DEFRA
previously approved these changes
Mar 2, 2022
tobyprivett
changed the title
active_registration for an OrderItemLog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/RUBY-1787
Before exporting a copy card item, we need to check that the
registration is active
Here we mixin the
CanCheckRegistrationStatusconcernand declare that an
OrderItemLog belongs_to RegistrationAnd we update the existing specs to ensure that the
Registrationis persisted before it is assigned to the
OrderItemLog