Enter contact address manually #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WC-113 Overseas users, or users who can't use the postcode lookup for whatever reason, should have the opportunity to enter their address manually. This should behave the same way as the manual address entry form for the registered address.
Currently this is a copy of the registered address manual forms, but renamed as appropriate. References to the contact postcode form are commented out until we merge #117
Create a subclass of BaseForm which CompanyAddressManualForm and ContactAddressManualForm inherit from, to reduce dupliation as both forms are very similar. (Turns out there was a lot of duplication!)
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
|
I've had a look, and am happy to approve, but I think they'll be some changes once you merge #117 that are best just done here, which will then invalidate that approval. Let me know when merged and this branch rebased, and I'll come back and approve then. |
If OS Places doesn't have any results for the postcode search, include a link to let users enter the address themselves.
|
@Cruikshanks That makes sense. I've merged in the postcode bits, so this should be ready for a review now. |
Cruikshanks
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WC-113
Overseas users, or users who can't use the postcode lookup for whatever reason, should have the opportunity to enter their address manually.
This should behave the same way as the manual address entry form for the registered address.
Because the postcode page has been set up in a separate branch (#117) references to the contact_postcode_form have been removed for now. So this is probably best tested with an overseas registration if you want a realistic representation of the form in the workflow.