-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor callback service and controller #1201
Conversation
…paration for govpay
… and add govpay support
…based on feature toggle
…tatus in the order and payment models
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The controllers look to be as compact as they can be without becoming unreadable and the request specs are pretty thorough. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can tell looks good :D
waste_carriers_engine: | ||
renewal_received_pending_govpay_payment_forms: | ||
new: | ||
title: Application received |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it matter if the text doesn't have speech marks for the whole file? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed: Team preferences is to not use quotes unless necessary, so I have updated the two locale files in the PR accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing chunk of work! looks ready to go to QA 👍
8638e2a
This change refactors the Govpay payment callback route and service to better reflect the Govpay payment flow, as opposed to aligning closely with the Worldpay payment flow. It also removes a redundant second call to the Govpay API to query payment status.
https://eaflood.atlassian.net/browse/RUBY-1891
https://eaflood.atlassian.net/browse/RUBY-1892
https://eaflood.atlassian.net/browse/RUBY-1893
https://eaflood.atlassian.net/browse/RUBY-1894