Refactor callback service and controller #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…paration for govpay
… and add govpay support
…based on feature toggle
…tatus in the order and payment models
kennyevil
previously approved these changes
Jun 21, 2022
Beckyrose200
previously approved these changes
Jun 21, 2022
| waste_carriers_engine: | ||
| renewal_received_pending_govpay_payment_forms: | ||
| new: | ||
| title: Application received |
There was a problem hiding this comment.
Does it matter if the text doesn't have speech marks for the whole file? :)
There was a problem hiding this comment.
As discussed: Team preferences is to not use quotes unless necessary, so I have updated the two locale files in the PR accordingly.
d-a-v-e
previously approved these changes
Jun 21, 2022
PaulDoyle-DEFRA
dismissed stale reviews from d-a-v-e, Beckyrose200, and kennyevil
via
8638e2a
d-a-v-e
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the Govpay payment callback route and service to better reflect the Govpay payment flow, as opposed to aligning closely with the Worldpay payment flow. It also removes a redundant second call to the Govpay API to query payment status.
https://eaflood.atlassian.net/browse/RUBY-1891
https://eaflood.atlassian.net/browse/RUBY-1892
https://eaflood.atlassian.net/browse/RUBY-1893
https://eaflood.atlassian.net/browse/RUBY-1894