-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby 2794 wcr track comminications history per registration #1485
Merged
jjromeo
merged 13 commits into
main
from
RUBY-2794-wcr-track-comminications-history-per-registration
Jan 8, 2024
Merged
Ruby 2794 wcr track comminications history per registration #1485
jjromeo
merged 13 commits into
main
from
RUBY-2794-wcr-track-comminications-history-per-registration
Jan 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and comms labels, and add communication record creation in WasteCarriersEngine.
…tion services - Implement CommunicationRecord model to track notification history. - Associate CommunicationRecords with Registration model. - Include CanRecordCommunication concern for recording notifications. - Update Notify services to create CommunicationRecords upon successful notification delivery. - Add specs for communication record creation in Notify
…r registration and deregistration - Fix mistake with constants - Refactor notification client response mocks in deregistration confirmation and email service specs
…annels and update tests
…cords and update references across models and specs
…efault in WasteCarriersEngine
…ault contact in `CanRecordCommunication` concern.
…into RUBY-2794-wcr-track-comminications-history-per-registration
…ail services and specs
…into RUBY-2794-wcr-track-comminications-history-per-registration
brujeo
approved these changes
Jan 8, 2024
jjromeo
deleted the
RUBY-2794-wcr-track-comminications-history-per-registration
branch
January 8, 2024 12:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.