Add more missing attributes to registrations #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This attribute includes the original date of expiry for former IR registrations.
This is used in the waste-carriers-frontend and waste-carriers-service.
The list of attributes continues to grow and is getting disorderly. So let's just alphabetise it so it's easier to find or add stuff.
irisfaraway
changed the title
irisfaraway
changed the title
waste-carriers-frontend calls this attribute companyNo. However the waste-carriers-service uses a snake_case version, and that is what is actually saved to the database. We aliased this anyway, so luckily it's a quick fix.
irisfaraway
added a commit
to DEFRA/waste-carriers-front-office
that referenced
this pull request
Jul 27, 2018
See DEFRA/waste-carriers-engine#223 for further details.
|
The |
Cruikshanks
approved these changes
Jul 30, 2018
irisfaraway
added a commit
to DEFRA/waste-carriers-front-office
that referenced
this pull request
Jul 30, 2018
* Fix seeding after field renaming We renamed some fields from camelCase to snake_case after the Java 8 upgrade on waste-carriers-service. Now that the model has been updated, the seeds need to be modified too. * Rename companyNo to company_no See DEFRA/waste-carriers-engine#223 for further details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few more missing attributes to the registrations. These are attributes which are occasionally used in waste-carriers-frontend or waste-carriers-service.
Since waste-carriers-service is the one interacting with the DB, I focused on its attributes over the frontend (which has several temporary ones which are not persisted, so hopefully irrelevant).
I also alphabetised the list of attributes as it was getting a bit unwieldy.