Cancelling Worldpay payment returns error message #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WC-394 Rather than showing a more informative message when cancelling a Worldpay payment, we get an 'Invalid response' error. This is caused because we are unable to build a valid MAC for a cancelled order if the user chooses to cancel their payment. In that case, the parameters we get back do not include the paymentAmount, the paymentCurrency or the paymentStatus. Instead we have orderAmount and orderCurrency. We need to modify the params we receive for a cancelled payment so we can properly validate them, including the MAC.
- If paymentCurrency is blank, replace with orderCurrency - If paymentAmount is blank, replace with orderAmount - If paymentStatus is blank, replace with 'CANCELLED' - Leave 'CANCELLED' status out of the MAC when generating it Plus tests to cover all this.
Cruikshanks
reviewed
Aug 6, 2018
| @@ -4,8 +4,9 @@ en: | |||
| failure: | |||
| invalid_response: "Invalid WorldPay failure response" | |||
| message: | |||
| REFUSED: "Your payment has been refused. Please try again or select a different payment method." | |||
| CANCELLED: "Your payment has been cancelled. Please try again or select a different payment method." | |||
There was a problem hiding this comment.
Not a content bod, but should this read more along the lines
Your attempt to pay was cancelled.
To my ears it currently sounds like payment was completed, and then subsequently cancelled. What do you 🤔 💭 ?
There was a problem hiding this comment.
Good point. Will change it now!
There was a problem hiding this comment.
@Cruikshanks Aaaand updated.
Cruikshanks
approved these changes
Aug 6, 2018
|
Build is failing because VCR cassettes are out of date. Fixing now: #235 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WC-394
Rather than showing a more informative message when cancelling a Worldpay payment, we get an 'Invalid response' error. This is caused because we are unable to build a valid MAC for a cancelled order if the user chooses to cancel their payment. In that case, the parameters we get back do not include the paymentAmount, the paymentCurrency or the paymentStatus. Instead we have orderAmount and orderCurrency.
We need to modify the params we receive for a cancelled payment so we can properly validate them, including the MAC.