Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate house number in addresses #280

Closed
wants to merge 3 commits into from

Conversation

irisfaraway
Copy link
Member

https://eaflood.atlassian.net/browse/WC-500

Addresses created in the renewals journey can display as having a duplicate house number when they are used by waste-carriers-frontend, for example:

123
123 Waste Street
Wastetown
AB1 2CD

This is because the renewals engine assigns the values of address_lines in a different way. For consistency's sake, we should change this to match how waste-carriers-frontend does it.


🔥 WIP 🔥

https://eaflood.atlassian.net/browse/WC-500

Addresses created in the renewals journey can display as having a duplicate house number when they are used by waste-carriers-frontend, for example:

123
123 Waste Street
Wastetown
AB1 2CD

This is because the renewals engine assigns the values of address_lines in a different way. For consistency's sake, we should change this to match how waste-carriers-frontend does it.
The `address_line` fields should be built using the `buildingNumber` and `lines` provided by OS Places.
Rather than try to determine the correct order ourselves, we stick to what OS Places provides, and put the building number as the first address line if it is present. This should make us consistent with waste-carriers-frontend.
@irisfaraway
Copy link
Member Author

Replacing with #281 as it turns out waste-carriers-frontend behaves a little differently.

@irisfaraway irisfaraway deleted the fix/consistent-addresses branch October 10, 2018 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant