Duplicate house number in addresses #280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WC-500 Addresses created in the renewals journey can display as having a duplicate house number when they are used by waste-carriers-frontend, for example: 123 123 Waste Street Wastetown AB1 2CD This is because the renewals engine assigns the values of address_lines in a different way. For consistency's sake, we should change this to match how waste-carriers-frontend does it.
The `address_line` fields should be built using the `buildingNumber` and `lines` provided by OS Places.
Rather than try to determine the correct order ourselves, we stick to what OS Places provides, and put the building number as the first address line if it is present. This should make us consistent with waste-carriers-frontend.
|
Replacing with #281 as it turns out waste-carriers-frontend behaves a little differently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WC-500
Addresses created in the renewals journey can display as having a duplicate house number when they are used by waste-carriers-frontend, for example:
123
123 Waste Street
Wastetown
AB1 2CD
This is because the renewals engine assigns the values of address_lines in a different way. For consistency's sake, we should change this to match how waste-carriers-frontend does it.
🔥 WIP 🔥