Remove reference from worldpay airbrake message #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We intended to use Airbrake to track our worldpay responses so we could get a better understanding of why they sometimes fail. When we first did this we included the registration reference in the message we were sending to Errbit not realising this would break Errbit's collation logic. If Errbit receives the same error as previous, rather than create a new entry it instead records it against the initial record. In this way you can distinguish that your app has 'x' errors, and they have each occurred 'y' number of times. By breaking the collation logic, it now appears we have hundreds of errors, each only occurring once. This changes removes the reference from the message we send to fix this. We still get the reference number as its included in the params that get attached.
irisfaraway
approved these changes
Apr 23, 2019
cintamani
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We intended to use Airbrake to track our worldpay responses so we could get a better understanding of why they sometimes fail.
When we first did this we included the registration reference in the message we were sending to Errbit not realising this would break Errbit's collation logic.
If Errbit receives the same error as previous, rather than create a new entry it instead records it against the initial record. In this way you can distinguish that your app has 'x' errors, and they have each occurred 'y' number of times.
By breaking the collation logic, it now appears we have hundreds of errors, each only occurring once.
This changes removes the reference from the message we send to fix this. We still get the reference number as its included in the params that get attached.