Forms refactoring - Tidy up #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some minor tidy-ups in this PR: - Get rid of `initialize` implementation on children forms that only call `super` - Make sure we always access `transient_registration` through its `attr_accessor` method - Move validations declaration to the top of the file, between class methods definitions and instance methods definitions
cintamani
changed the title
Cruikshanks
previously requested changes
Oct 9, 2019
There was a problem hiding this comment.
You started something in app/forms/waste_carriers_engine/bank_transfer_form.rb that I started spotting wasn't there on others, and before I knew it I'd made a rod for my own back.
I perhaps should have said remove the extra line (would have been far less instances), but I think it is better with one there 😩 😁
Other than that, I have zero issues with this!
cintamani
commented
Oct 9, 2019
cintamani
commented
Oct 9, 2019
cintamani
commented
Oct 9, 2019
cintamani
commented
Oct 9, 2019
cintamani
commented
Oct 9, 2019
Co-Authored-By: Alan Cruikshanks <alan.cruikshanks@gmail.com>
Cruikshanks
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: https://eaflood.atlassian.net/browse/RUBY-693
There are some minor tidy-ups in this PR:
initializeimplementation on children forms that only callsupertransient_registrationthrough itsattr_accessormethod