-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forms refactoring - Tidy up #487
Conversation
There are some minor tidy-ups in this PR: - Get rid of `initialize` implementation on children forms that only call `super` - Make sure we always access `transient_registration` through its `attr_accessor` method - Move validations declaration to the top of the file, between class methods definitions and instance methods definitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You started something in app/forms/waste_carriers_engine/bank_transfer_form.rb
that I started spotting wasn't there on others, and before I knew it I'd made a rod for my own back.
I perhaps should have said remove the extra line (would have been far less instances), but I think it is better with one there 😩 😁
Other than that, I have zero issues with this!
Co-Authored-By: Alan Cruikshanks <alan.cruikshanks@gmail.com>
From: https://eaflood.atlassian.net/browse/RUBY-693
There are some minor tidy-ups in this PR:
initialize
implementation on children forms that only callsuper
transient_registration
through itsattr_accessor
method