Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forms refactoring - Tidy up #487

Merged
merged 4 commits into from
Oct 9, 2019
Merged

Forms refactoring - Tidy up #487

merged 4 commits into from
Oct 9, 2019

Commits on Oct 8, 2019

  1. Forms refactoring - Tidy up 

    There are some minor tidy-ups in this PR:
 - Get rid of `initialize` implementation on children forms that only call `super`
 - Make sure we always access `transient_registration` through its `attr_accessor` method
 - Move validations declaration to the top of the file, between class methods definitions and instance methods definitions
    @cintamani
    cintamani committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    c7074c4 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2019

  1. Apply suggestions from code review 

    Co-Authored-By: Alan Cruikshanks <alan.cruikshanks@gmail.com>
    @cintamani @Cruikshanks
    cintamani and Cruikshanks authored Oct 9, 2019
    Configuration menu
    Copy the full SHA
    b25113c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into tidy-up

    @cintamani
    cintamani authored Oct 9, 2019
    Configuration menu
    Copy the full SHA
    6ba4a8e View commit details
    Browse the repository at this point in the history

  3. Fix rubocop

    @cintamani
    cintamani committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    68ca969 View commit details
    Browse the repository at this point in the history