Forms refactoring - Remove extra reg_identifier param on submit #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From: https://eaflood.atlassian.net/browse/RUBY-693 Remove extra reg_identifier parameter in the `submit` method. If necessary, it will be passed through the form parameters.
cintamani
force-pushed
the
forms-refactoring-remove-reg-identifier-from-submit
branch
from
17b43ff
to
762c349
Compare
cintamani
changed the base branch from
form-refactoring-submit-assign-validate
to
master
|
Codeclimate is a won't fix. Those will all be gone soon. |
cintamani
changed the title
cintamani
changed the title
cintamani
changed the title
Cruikshanks
approved these changes
Oct 9, 2019
cintamani
deleted the
forms-refactoring-remove-reg-identifier-from-submit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: https://eaflood.atlassian.net/browse/RUBY-693
Remove extra reg_identifier parameter in the
submitmethod. If necessary, it will be passed through the form parameters.