Add start form for new registrations #695
Conversation
From: https://eaflood.atlassian.net/browse/RUBY-840 This adds a new page to the services which allow a user to start a new registration journey. The page is part of the new registration workflow.
…ansient registration is of type new registration. In WEX, we do not check for the presence and format of a reference so we might later decide to remove this check entirely and move it to relevant start forms only.
…start form. We will need to do further refactoring on the way we authenticate users on each separate journey.
|
@cintamani I've removed myself and @irisfaraway as reviewers as I know we suggested the tweak about prefixing the start option with So figured it makes our TODO list a little clearer if we remove ourselves for now and then you add us again when the changes have been made. |
|
Yes definitely! Thanks guys :) will ping you when it is ready again |
cintamani
changed the title
app/controllers/waste_carriers_engine/renew_registration_forms_controller.rb
Outdated
Show resolved
Hide resolved
|
The missing test coverage is for the temporary renewing registration forms and controller which will be implemented and properly tested as per RUBY-841 Hence I am going to ignore codeclimate's complain in this PR. |
cintamani
changed the title
| @@ -46,6 +46,7 @@ module WasteCarriersEngine | |||
| context "when the resource is not a transient_registration" do | |||
There was a problem hiding this comment.
Is this accurate? A NewRegistration is still a type of TransientRegistration.
There was a problem hiding this comment.
yes, this is not testing the validity of a new_regisration object in the base_form, but the validity of a registration object passed as a transient registration, so is still correct. You could argue that there is no test coverage for when we have a transient registration that is of type new registration, but as we discussed during the dev meeting we aren't sure about keeping this validation at all, and I will have to sort it out for validating the correct CBDU/CBDL numbers are generated later on so I just added that is_a? as a placeholder and make things pass now. We will need to go in more details about that in some other PR/meeting :D
There was a problem hiding this comment.
So the first allow is making sure that is_a?(TransientRegistration) always returns false, but the second allow makes sure we still actually call is_a?(NewRegistration) and use the real response – am I understanding this right?
There was a problem hiding this comment.
No, the second call is stubbing is_a?(NewRegistration) and making it return nil
spec/models/waste_carriers_engine/new_registration_workflow/start_form_spec.rb
Show resolved
Hide resolved
Co-Authored-By: Iris Faraway <iris.faraway@gmail.com>
From: https://eaflood.atlassian.net/browse/RUBY-840
This adds a new page to the services which allow a user to start a new registration journey.
The page is part of the new registration workflow.
I suggest reviewing by separate commits