Set up workflow for edit payments by bank transfer #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/RUBY-833 This is part of a set of multiple PRs to configure payment when a carrier type changes during editing. This PR sets up the workflow and pages for paying for an edit by bank transfer. This includes the payment summary and bank transfer info pages. WorldPay will be added separately in a future PR.
This includes several new partials which can hopefully be reused on similar pages.
This includes a shared partial which can hopefully be reused on other similar pages.
|
This PR looks big, but should be manageable commit-by-commit. |
|
I am wondering since the layout of the pages is almost the same, why are we generating new forms for these and not reusing the existing ones we already share with new and renewing registrations? |
|
@cintamani We already had different controllers for the copy cards payment pages, so I was following that pattern. There are some differences in the text around options, for example. Although I think that with the way I've rewritten the code, we may now be able to reuse it across all the different payment pages. I was thinking of getting this merged in as-is and then merging all the various duplicated payment forms in a separate PR so as not to bloat this one even more – what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/RUBY-833
This is part of a set of multiple PRs to configure payment when a carrier type changes during editing.
This PR sets up the workflow and pages for paying for an edit by bank transfer. This includes the payment summary and bank transfer info pages.
WorldPay will be added separately in a future PR.