Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix W3C fail with tel. no. on reg. complete page #770

Merged
merged 2 commits into from
Apr 1, 2020

Conversation

Cruikshanks
Copy link
Member

https://eaflood.atlassian.net/browse/RUBY-918

During the QA of adding a new registration completion page we spotted a W3C validation error being reported.

Specifically it doesn't like that there are spaces in the tel: attribute of the href element we use to display NCCC's telephone number.

This fix resolves the issue.

https://eaflood.atlassian.net/browse/RUBY-918

During the QA of adding a new registration completion page we spotted a W3C validation error being reported.

Specifically it doesn't like that there are spaces in the `tel:` attribute of the **href** element we use to display NCCC's telephone number.

This fix resolves the issue.
@Cruikshanks Cruikshanks added the bug Something isn't working label Apr 1, 2020
@Cruikshanks Cruikshanks self-assigned this Apr 1, 2020
@Cruikshanks Cruikshanks marked this pull request as ready for review April 1, 2020 15:18
Copy link
Contributor

@andrewhick andrewhick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me :)

@Cruikshanks Cruikshanks merged commit 281a17f into master Apr 1, 2020
@Cruikshanks Cruikshanks deleted the fix-completion-page-tel-number-w3c-fail branch April 1, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants