Skip to content

Commit

Permalink
Fix W3C fail with tel. no. on reg. complete page (#770)
Browse files Browse the repository at this point in the history
https://eaflood.atlassian.net/browse/RUBY-918

During the QA of adding a new registration completion page we spotted a W3C validation error being reported.

Specifically it doesn't like that there are spaces in the `tel:` attribute of the **href** element we use to display NCCC's telephone number.

This fix resolves the issue.
  • Loading branch information
Cruikshanks committed Apr 1, 2020
1 parent cb17e60 commit 281a17f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<p>
<%= t(".telephone.heading") %>
<br>
<a href="tel:<%= t(".telephone.value") %>"><%= t(".telephone.value") %></a>
<a href="tel:<%= t(".telephone.value.href") %>"><%= t(".telephone.value.display") %></a>
</p>

<h2 class="heading-medium"><%= t(".subheading_3") %></h2>
Expand Down
4 changes: 3 additions & 1 deletion config/locales/forms/registration_completed_forms/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ en:
value: "nccc-carrierbroker@environment-agency.gov.uk"
telephone:
heading: "Telephone"
value: "03708 506 506"
value:
display: "03708 506 506"
href: "03708506506"
subheading_2: "If your details change"
paragraph_2: "If any of the details you've given us change, you must update them within 28 days by contacting the Environment Agency."
subheading_3: "Registration checks"
Expand Down

0 comments on commit 281a17f

Please sign in to comment.