Add 'are you sure?' screen when paying by bank transfer #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/RUBY-1004 Users are confused by the current bank transfer flow. An 'are you sure?' page has been added to help users pay by bank transfer. This replaces the existing bank transfer information page. All details for how to pay by bank transfer will be moved to the page at the end of the journey as part of RUBY-1005. This only applies to the new registration and renewals journey. Edit and ordering copy cards are not affected.
Also stop the CopyCardsBankTransferForm from inheriting, since it will no longer have the same delegated attribute.
irisfaraway
added a commit
that referenced
this pull request
Apr 30, 2020
https://eaflood.atlassian.net/browse/RUBY-1005 Users expect the bank transfer details to be on the final confirmation screen once they have submitted their registration. This change adds the details to the confirmation page for new registrations. Renewals will be updated in a separate PR. This works in combination with #820, which removes the bank transfer info from the preceding page in both journeys.
cintamani
reviewed
Apr 30, 2020
| @@ -1,6 +1,11 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| module WasteCarriersEngine | |||
| class CopyCardsBankTransferForm < BankTransferForm | |||
| class CopyCardsBankTransferForm < BaseForm | |||
There was a problem hiding this comment.
Why are we changing this? I thought the scope of the ticket wasn't including copy cards flow?
There was a problem hiding this comment.
Ah! Never mind. I got it :)
cintamani
approved these changes
Apr 30, 2020
irisfaraway
added a commit
that referenced
this pull request
Apr 30, 2020
https://eaflood.atlassian.net/browse/RUBY-1005 Users expect the bank transfer details to be on the final confirmation screen once they have submitted their registration. This change adds the details to the confirmation page for new registrations. Renewals will be updated in a separate PR. This works in combination with #820, which removes the bank transfer info from the preceding page in both journeys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/RUBY-1004
Users are confused by the current bank transfer flow. An 'are you sure?' page has been added to help users pay by bank transfer.
This replaces the existing bank transfer information page. All details for how to pay by bank transfer will be moved to the page at the end of the journey as part of RUBY-1005.
This only applies to the new registration and renewals journey. Edit and ordering copy cards are not affected.