Add 'are you sure?' screen when paying by bank transfer

app/controllers/waste_carriers_engine/bank_transfer_forms_controller.rb → app/controllers/waste_carriers_engine/confirm_bank_transfer_forms_controller.rb

@@ -1,15 +1,15 @@
 # frozen_string_literal: true
 
 module WasteCarriersEngine
-  class BankTransferFormsController < FormsController
+  class ConfirmBankTransferFormsController < FormsController
     def new
-      return unless super(BankTransferForm, "bank_transfer_form")
+      return unless super(ConfirmBankTransferForm, "confirm_bank_transfer_form")
 
       set_up_finance_details
     end
 
     def create
-      super(BankTransferForm, "bank_transfer_form")
+      super(ConfirmBankTransferForm, "confirm_bank_transfer_form")
     end
 
     private

app/forms/waste_carriers_engine/bank_transfer_form.rb → app/forms/waste_carriers_engine/confirm_bank_transfer_form.rb

@@ -1,9 +1,7 @@
 # frozen_string_literal: true
 
 module WasteCarriersEngine
-  class BankTransferForm < BaseForm
-    delegate :total_to_pay, to: :transient_registration
-
+  class ConfirmBankTransferForm < BaseForm
     def self.can_navigate_flexibly?
       false
     end

app/forms/waste_carriers_engine/copy_cards_bank_transfer_form.rb

@@ -1,6 +1,11 @@
 # frozen_string_literal: true
 
 module WasteCarriersEngine
-  class CopyCardsBankTransferForm < BankTransferForm
+  class CopyCardsBankTransferForm < BaseForm
+    delegate :total_to_pay, to: :transient_registration
+
+    def self.can_navigate_flexibly?
+      false
+    end
   end
 end

app/models/concerns/waste_carriers_engine/can_use_new_registration_workflow.rb

@@ -62,7 +62,7 @@ module CanUseNewRegistrationWorkflow
         state :cards_form
         state :payment_summary_form
         state :worldpay_form
-        state :bank_transfer_form
+        state :confirm_bank_transfer_form
 
         state :registration_completed_form
         state :registration_received_pending_payment_form
@@ -290,10 +290,10 @@ module CanUseNewRegistrationWorkflow
                       if: :paying_by_card?
 
           transitions from: :payment_summary_form,
-                      to: :bank_transfer_form
+                      to: :confirm_bank_transfer_form
 
           # Registration completion forms
-          transitions from: :bank_transfer_form,
+          transitions from: :confirm_bank_transfer_form,
                       to: :registration_received_pending_payment_form,
                       # TODO: This don't get triggered if in the `success`
                       # callback block, hence we went for `after`
@@ -517,7 +517,7 @@ module CanUseNewRegistrationWorkflow
           transitions from: :worldpay_form,
                       to: :payment_summary_form
 
-          transitions from: :bank_transfer_form,
+          transitions from: :confirm_bank_transfer_form,
                       to: :payment_summary_form
         end
 

app/models/concerns/waste_carriers_engine/can_use_renewing_registration_workflow.rb

@@ -55,7 +55,7 @@ module CanUseRenewingRegistrationWorkflow
         state :cards_form
         state :payment_summary_form
         state :worldpay_form
-        state :bank_transfer_form
+        state :confirm_bank_transfer_form
 
         state :renewal_complete_form
         state :renewal_received_form
@@ -257,7 +257,7 @@ module CanUseRenewingRegistrationWorkflow
                       if: :paying_by_card?
 
           transitions from: :payment_summary_form,
-                      to: :bank_transfer_form
+                      to: :confirm_bank_transfer_form
 
           transitions from: :worldpay_form,
                       to: :renewal_received_form,
@@ -273,7 +273,7 @@ module CanUseRenewingRegistrationWorkflow
                       # callback block, hence we went for `after`
                       after: :set_metadata_route
 
-          transitions from: :bank_transfer_form,
+          transitions from: :confirm_bank_transfer_form,
                       to: :renewal_received_form,
                       success: :send_renewal_received_email,
                       # TODO: This don't get triggered if in the `success`
@@ -450,7 +450,7 @@ module CanUseRenewingRegistrationWorkflow
           transitions from: :worldpay_form,
                       to: :payment_summary_form
 
-          transitions from: :bank_transfer_form,
+          transitions from: :confirm_bank_transfer_form,
                       to: :payment_summary_form
 
           # Exit routes from renewals process

app/views/waste_carriers_engine/confirm_bank_transfer_forms/new.html.erb

@@ -0,0 +1,24 @@
+<%= render("waste_carriers_engine/shared/back", back_path: back_confirm_bank_transfer_forms_path(@confirm_bank_transfer_form.token)) %>
+
+<div class="text">
+  <%= form_for(@confirm_bank_transfer_form) do |f| %>
+    <h1 class="heading-large"><%= t(".heading") %></h1>
+
+    <p>
+      <%= t(".paragraph_1") %>
+    </p>
+
+    <p>
+      <%= t(".paragraph_2") %>
+    </p>
+
+    <p>
+      <%= link_to(t(".link_text"),
+                  back_confirm_bank_transfer_forms_path(@confirm_bank_transfer_form.token)) %>
+    </p>
+
+    <div class="form-group">
+      <%= f.submit t(".next_button"), class: "button" %>
+    </div>
+  <% end %>
+</div>

config/locales/forms/confirm_bank_transfer_forms/en.yml

@@ -0,0 +1,10 @@
+en:
+  waste_carriers_engine:
+    confirm_bank_transfer_forms:
+      new:
+        title: Pay by bank transfer
+        heading: Registration takes longer if you pay by bank transfer
+        paragraph_1: "In order to pay by bank transfer, you will need to follow the instructions on the next screen and email us to confirm payment. This will take approximately 5 working days."
+        paragraph_2: "In most cases we can provide instant confirmation if you pay by card."
+        link_text: "Go back to pay by credit or debit card instead"
+        next_button: "Confirm you’ll pay by bank transfer"

config/routes.rb

@@ -566,12 +566,12 @@
                     on: :collection
               end
 
-    resources :bank_transfer_forms,
+    resources :confirm_bank_transfer_forms,
               only: %i[new create],
-              path: "bank-transfer",
+              path: "confirm-bank-transfer",
               path_names: { new: "" } do
                 get "back",
-                    to: "bank_transfer_forms#go_back",
+                    to: "confirm_bank_transfer_forms#go_back",
                     as: "back",
                     on: :collection
               end

spec/factories/forms/bank_transfer_form.rb → spec/factories/forms/confirm_bank_transfer_form.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :bank_transfer_form, class: WasteCarriersEngine::BankTransferForm do
+  factory :confirm_bank_transfer_form, class: WasteCarriersEngine::ConfirmBankTransferForm do
     trait :has_required_data do
-      initialize_with { new(create(:renewing_registration, :has_required_data, workflow_state: "bank_transfer_form")) }
+      initialize_with { new(create(:renewing_registration, :has_required_data, workflow_state: "confirm_bank_transfer_form")) }
     end
   end
 end

spec/forms/waste_carriers_engine/confirm_bank_transfer_forms_spec.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+require "rails_helper"
+
+module WasteCarriersEngine
+  RSpec.describe ConfirmBankTransferForm, type: :model do
+    describe "#submit" do
+      let(:confirm_bank_transfer_form) { build(:confirm_bank_transfer_form, :has_required_data) }
+
+      context "when the form is valid" do
+        let(:valid_params) { { token: confirm_bank_transfer_form.token } }
+
+        it "should submit" do
+          expect(confirm_bank_transfer_form.submit(valid_params)).to eq(true)
+        end
+      end
+
+      context "when the form is not valid" do
+        before do
+          expect(confirm_bank_transfer_form).to receive(:valid?).and_return(false)
+        end
+
+        it "should not submit" do
+          expect(confirm_bank_transfer_form.submit({})).to eq(false)
+        end
+      end
+    end
+  end
+end

spec/models/waste_carriers_engine/new_registration_workflow/bank_transfer_form_spec.rb → spec/models/waste_carriers_engine/new_registration_workflow/confirm_bank_transfer_form_spec.rb

@@ -4,10 +4,10 @@
 
 module WasteCarriersEngine
   RSpec.describe NewRegistration do
-    subject { build(:new_registration, workflow_state: "bank_transfer_form") }
+    subject { build(:new_registration, workflow_state: "confirm_bank_transfer_form") }
 
     describe "#workflow_state" do
-      context ":bank_transfer_form state transitions" do
+      context ":confirm_bank_transfer_form state transitions" do
         context "on next" do
           include_examples "has next transition", next_state: "registration_received_pending_payment_form"
 

spec/models/waste_carriers_engine/new_registration_workflow/payment_summary_form_spec.rb

@@ -15,7 +15,7 @@ module WasteCarriersEngine
             include_examples "has next transition", next_state: "worldpay_form"
           end
 
-          include_examples "has next transition", next_state: "bank_transfer_form"
+          include_examples "has next transition", next_state: "confirm_bank_transfer_form"
         end
 
         context "on back" do

spec/models/waste_carriers_engine/renewing_registration_spec.rb

@@ -19,11 +19,11 @@ module WasteCarriersEngine
         end
       end
 
-      context "when transitioning from bank_transfer_form to renewal_received_form succesfully" do
+      context "when transitioning from confirm_bank_transfer_form to renewal_received_form succesfully" do
         it "set the transient registration metadata route" do
           expect(renewing_registration).to receive(:set_metadata_route).once
 
-          renewing_registration.update_attributes(workflow_state: :bank_transfer_form)
+          renewing_registration.update_attributes(workflow_state: :confirm_bank_transfer_form)
           renewing_registration.next
         end
       end