Add new confirmation screen for pending WorldPay payment #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From: https://eaflood.atlassian.net/browse/RUBY-1013 This adds a new completion screen for when a WorldPay payment is pending
|
SonarCloud doesn't like the email template, as usual, so ignoring it |
irisfaraway
reviewed
May 5, 2020
config/locales/forms/registration_received_pending_worldpay_payment_forms/en.yml
Show resolved
Hide resolved
Co-authored-by: Iris Faraway <iris.faraway@gmail.com>
|
Yes, I am all in favour of splitted controllers. I hate to deal with too many ifs and maintenance of the code will improve. |
irisfaraway
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: https://eaflood.atlassian.net/browse/RUBY-1013
This adds a new completion screen for when a WorldPay payment is pending
Screen
Email