Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registration already renewed screen for magic link error #839

Merged
merged 5 commits into from
May 15, 2020

Conversation

cintamani
Copy link
Contributor

@cintamani cintamani commented May 14, 2020

From:https://eaflood.atlassian.net/browse/RUBY-1001

This adds an ad-hoc screen when the renewal link is hit after a registration has already been renewed

Screenshot 2020-05-14 at 13 56 15

From:https://eaflood.atlassian.net/browse/RUBY-1001

This adds an ad-hoc screen when the renewal link is hit after a registration has already been renewed
@cintamani cintamani added the enhancement New feature or request label May 14, 2020
@cintamani cintamani self-assigned this May 14, 2020
Copy link
Member

@irisfaraway irisfaraway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some quibbles! Let me know if you'd like to discuss anything.

app/services/waste_carriers_engine/expiry_check_service.rb Outdated Show resolved Hide resolved
config/locales/forms/renews/en.yml Outdated Show resolved Hide resolved
app/models/waste_carriers_engine/registration.rb Outdated Show resolved Hide resolved
Co-authored-by: Iris Faraway <iris.faraway@gmail.com>
@cintamani cintamani dismissed irisfaraway’s stale review May 15, 2020 11:24

dismissing so I can merge

@cintamani cintamani merged commit 895d90b into master May 15, 2020
@Cruikshanks Cruikshanks deleted the 1001-already-renewed branch July 2, 2020 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants