Generate renewal token when one is requested #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/RUBY-1166 If a registration is eligible for renewal NCCC would like us to display the same renewal link that gets included in the renewal reminder emails and letters in registration details. Currently though we only generate the token used in the link when first generating the reminder email. A registration is eligible for renewal before this is done. And when we first release there will be hundreds that are eligible which will never go through the reminder process because it is too late. The simplest solution we have for this is to generate it if required. This way we avoid any timing issues or another scheduled task that would have to try and identify all eligible registrations and update them in one go. So this change will add some logic to automatically generate and save a token if one does not exist when the token is requested.
Kept getting messages about using the wrong version of bundler when trying to run up the rails console in the dummy app. Spotted that we had a .ruby-version file with the old version in it. I could have corrected the version but actually there is no need for it to be here when we have one in the root of the project.
Documentation was scant but found there is a way to override the default getter Mongoid provides. The key thing is to access the underlying data field you need to use `self[:field_name]`. So now we can just ask for `renew_token` where we need it, and one will be generated automatically if it doesn't exist.
We should no longer need to call this method when we can request `renew_token` directly.
Cruikshanks
added a commit
to DEFRA/waste-carriers-back-office
that referenced
this pull request
Jul 23, 2020
https://eaflood.atlassian.net/browse/RUBY-1166 If a registration is eligible for renewal NCCC would like us to display the same renewal link that gets included in the renewal reminder emails and letters in registration details. Currently though we only generate the token used in the link when first generating the reminder email. A registration is eligible for renewal before this is done. And when we first release there will be hundreds that are eligible which will never go through the reminder process because it is too late. The simplest solution we have for this is to generate it if required. We made that change in the engine in [PR #898](DEFRA/waste-carriers-engine#898). This change updates the back-office to use the new functionality.
|
@irisfaraway check out DEFRA/waste-carriers-back-office#962 to see how using this version of the engine affects the back-office 😁 |
|
More for future reference as finding examples of this was super-hard A subsequent answer recommends using |
irisfaraway
approved these changes
Jul 24, 2020
Cruikshanks
added a commit
to DEFRA/waste-carriers-back-office
that referenced
this pull request
Jul 24, 2020
https://eaflood.atlassian.net/browse/RUBY-1166 If a registration is eligible for renewal NCCC would like us to display the same renewal link that gets included in the renewal reminder emails and letters in registration details. Currently, though we only generate the token used in the link when first generating the reminder email. A registration is eligible for renewal before this is done. And when we first release there will be hundreds that are eligible which will never go through the reminder process because it is too late. The simplest solution we have for this is to generate it if required. We made that change in the engine in [PR #898](DEFRA/waste-carriers-engine#898). This change updates the back-office to use the new functionality.
Cruikshanks
added a commit
to DEFRA/waste-carriers-back-office
that referenced
this pull request
Jul 24, 2020
https://eaflood.atlassian.net/browse/RUBY-1166 If a registration is eligible for renewal NCCC would like us to display the same renewal link that gets included in the renewal reminder emails and letters in registration details. Currently though we only generate the token used in the link when first generating the reminder email. A registration is eligible for renewal before this is done. And when we first release there will be hundreds that are eligible which will never go through the reminder process because it is too late. The simplest solution we have for this is to generate it if required. We made that change in the engine in [PR #898](DEFRA/waste-carriers-engine#898). This change updates the back-office to use the new functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/RUBY-1166
If a registration is eligible for renewal NCCC would like us to display the same renewal link that gets included in the renewal reminder emails and letters in registration details.
Currently though we only generate the token used in the link when first generating the reminder email. A registration is eligible for renewal before this is done. And when we first release there will be hundreds that are eligible which will never go through the reminder process because it is too late.
The simplest solution we have for this is to generate it if required. This way we avoid any timing issues or another scheduled task that would have to try and identify all eligible registrations and update them in one go.
So this change will add some logic to automatically generate and save a token if one does not exist when the token is requested.