Do not copy receipt_email when init. renewal #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/RUBY-1172 This is the scenario - User creates a new registration using the new journey in the FO - User pays by card so a payment confirmation email is taken and :receipt_email is populated - 3 years later user renews but as AD Irrespective of how user pays, the renewed registration displays the payment confirmation section in Registration details As we know that the payment confirmation email is only sent for digital users renewing or creating new registrations its a one-time thing against the registration. So this means when a new renewal is initialised, we should not be copying the receipt email from the registration as it may not be applicable this time.
Cruikshanks
force-pushed
the
do-not-copy-receipt-email
branch
from
c4d745e
to
776dd78
Compare
irisfaraway
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/RUBY-1172
This is the scenario
Irrespective of how user pays, the renewed registration displays the payment confirmation section in Registration details
As we know that the payment confirmation email is only sent for digital users renewing or creating new registrations its a one-time thing against the registration.
So this means when a new renewal is initialised, we should not be copying the receipt email from the registration as it may not be applicable this time.