Switch airbrake mgmt to defra-ruby-alert #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cruikshanks
added
the
housekeeping
Cruikshanks
force-pushed
the
implement-defra-ruby-alert
branch
from
a50dda4
to
08ebf7e
Compare
This is a temporary change. Once the defra-ruby-alert PR for the engine has been merged this will be switched back to `master` and the Gemfile.lock updated to the correct commit hash.
Switching to defra-ruby-alert is complete in the waste-carriers-engine
Cruikshanks
force-pushed
the
implement-defra-ruby-alert
branch
from
08ebf7e
to
e3de719
Compare
cintamani
approved these changes
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst working on an issue for the Flood Risk Activity Exemptions service we came across an issue with Airbrake.
We wanted to add a new Rake task, and we wanted to apply our new pattern of ensuring Airbrake is closed when the task exits to ensure any errors are reported. The problem was due to the age of the Airbrake gem being used this caused an error in FRAE we hadn't seen in WEX and WCR.
So for reasons outlined in FRAE PR 312 we came up with defra-ruby-alert. The idea is going forward this will provide a single interface for configuring Airbrake and ensure the pattern of making sure all exceptions are reported before an app closes is applied consistently in all scenarios.
The main changes to enable this have been applied to the waste-carriers-engine.
These changes finalise the implementation for the front-office, switching out requiring and configuring Airbrake directly, to passing config details through to the WCR engine for it to do it.