Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch airbrake mgmt to defra-ruby-alert #395

Merged
merged 4 commits into from
Feb 7, 2020
Merged

Switch airbrake mgmt to defra-ruby-alert #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d800d08
Remove existing Airbrake reference and config
Cruikshanks Feb 4, 2020
e1fc833
Switch to engine branch with defra ruby alert imp.
Cruikshanks Feb 4, 2020
94a44ae
Add airbrake config to engine initializer
Cruikshanks Feb 4, 2020
e3de719
Switch back to WCR engine master branch
Cruikshanks Feb 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@
source "https://rubygems.org"
ruby "2.4.2"

# Use Airbrake for error reporting to Errbit
# Version 6 and above cause errors with Errbit, so use 5.8.1 for now
gem "airbrake", "5.8.1"
# Use CoffeeScript for .coffee assets and views
gem "coffee-rails", "~> 4.1.0"
# Build JSON APIs with ease. Read more: https://github.com/rails/jbuilder
Expand Down
6 changes: 4 additions & 2 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
GIT
remote: https://github.com/DEFRA/waste-carriers-engine
revision: af386580ef1f426f691fccfc4c87fb231d35a81a
revision: 7c2cb01a0227a02c2481cacf6271584027a634f9
branch: master
specs:
waste_carriers_engine (0.0.1)
aasm (~> 4.12)
countries
defra_ruby_alert (~> 1.0.0)
defra_ruby_validators
high_voltage (~> 3.0)
jbuilder (~> 2.0)
Expand Down Expand Up @@ -88,6 +89,8 @@ GEM
crass (1.0.6)
database_cleaner (1.8.2)
debug_inspector (0.0.3)
defra_ruby_alert (1.0.0)
airbrake (~> 5.8.1)
defra_ruby_mocks (1.3.0)
nokogiri
rails (~> 4.2.11.1)
Expand Down Expand Up @@ -346,7 +349,6 @@ PLATFORMS
ruby

DEPENDENCIES
airbrake (= 5.8.1)
aws-healthcheck
byebug
cancancan (~> 1.10)
Expand Down
68 changes: 0 additions & 68 deletions config/initializers/airbrake.rb
View file
Open in desktop

This file was deleted.

7 changes: 7 additions & 0 deletions config/initializers/waste_carriers_engine.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,11 @@
if ENV["WCRS_MOCK_ENABLED"].to_s.downcase == "true"
configuration.companies_house_host = ENV["WCRS_MOCK_BO_COMPANIES_HOUSE_URL"]
end

# Configure airbrake, which is done via the engine using defra_ruby_alert
configuration.airbrake_enabled = ENV["WCRS_USE_AIRBRAKE"]
configuration.airbrake_host = ENV["WCRS_AIRBRAKE_URL"]
configuration.airbrake_project_key = ENV["WCRS_FRONTOFFICE_AIRBRAKE_PROJECT_KEY"]
configuration.airbrake_blacklist = [/password/i, /authorization/i]
end
WasteCarriersEngine.start_airbrake