Validate A/AS level grades #3458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malcolmbaig
force-pushed
the
2508-a-level-grades-structured-input
branch
from
ab57614
to
4d33d42
Compare
|
Closing temporarily - needs a couple of changes |
malcolmbaig
force-pushed
the
2508-a-level-grades-structured-input
branch
from
4d33d42
to
7e57634
Compare
The Other Qualifications flow uses several string values to identify the qualification type. Using constants to refer these is useful because: - We can see the list of valid types handled by this flow in a single place (the top of the OtherQualificationWizard class) - The relationship between the string values and the places they are used is a little easier to see when scanning, and easier to grep for.
- Remove whitespace and upcase grades before validating the form - Validate by comparing against a list of standard A/AS level grades
malcolmbaig
requested review from
stevehook,
davidgisbey and
paulrobertlloyd
davidgisbey
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As a candidate
I need to… provide the required information efficiently and accurately
So that… I can complete my application
We want grade data for A/AS level qualifications to be more structured. It should remain a free text input because there are usability issues with autcompletes, radio buttons, and selects.
Changes proposed in this pull request
Guidance to review
Can be tested by adding an A/AS level in the review app.
Link to Trello card
https://trello.com/c/7sDY3Doc
Things to check