Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: improvement to gui/mass-remove #3369

Closed
fricy opened this issue May 14, 2023 · 5 comments · Fixed by DFHack/scripts#927
Closed

Suggestion: improvement to gui/mass-remove #3369

fricy opened this issue May 14, 2023 · 5 comments · Fixed by DFHack/scripts#927

Comments

@fricy
Copy link

fricy commented May 14, 2023

Edit: I'm an idiot, it already does that if all options are deselected. Maybe add that info into the description?
Issue can be closed.

Allow differentiating between buildings/constructions already built and only in the planning phase.

Use case: I need to remove a couple of walls designated by building planner. The material filter was not correct, and they are never getting built. However there are other construction on the area that the script will want to remove unless I micromanage it.

Implementation v1:
right now the settings are:
Construction: Leave alone/Remove

Updated:
Leave alone/Remove planned/Remove built/Remove all

Implementation v2:
Buildings: Leave alone
Constructions: Leave alone
Suspend: Leave alone
Planned: Remove

@fricy fricy closed this as completed May 14, 2023
@myk002
Copy link
Member

myk002 commented May 14, 2023

Planned constructions are actually buildings, and would be removed with the buildings option. If they're getting removed even with "leave buildings alone", then that might be a bug in itself.

@fricy
Copy link
Author

fricy commented May 16, 2023

No, it's the building option.
It just needs some tooltip or help text to make it easier to figure it out the first time.

@myk002
Copy link
Member

myk002 commented May 16, 2023

Maybe change "constructions" to "built constructions"?

@fricy
Copy link
Author

fricy commented May 17, 2023

Perhaps. But that option seems to be the most straightforward. It just removes built constructions.

The "Building" option however removes:
Furnitures
Doors
Machines
Traps
Workshops
Stockpiles
Planned constructions
Some constructions like trackstops and bridges

I don't know which is a game limitation, and which is an oversight in coding.

I'd suggest splitting that button into multiple options if possible:

Implementation v3:
Workshops (Stockpiles?)
Furniture (Doors, Nest boxes, Hives)
Machines and Traps (Levers, Trackstops, Axles)
Constructions (incl. Bridges)
Planned buildings/constr.
Suspend

And maybe an undo button/brush to reverse a misclick. At least for stuff that's already built, because planned buildings are cancelled on the fly.

@fricy fricy reopened this May 17, 2023
@myk002
Copy link
Member

myk002 commented Jun 19, 2023

And maybe an undo button/brush to reverse a misclick. At least for stuff that's already built, because planned buildings are cancelled on the fly.

Note that this "undo" functionality exists, but is currently commented out due to an issue with v50 crashing when we cancel a DeconstructBuilding job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants