Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use bay12-provided translate_name function #3826

Closed
ab9rf opened this issue Sep 29, 2023 · 0 comments · Fixed by #3833
Closed

use bay12-provided translate_name function #3826

ab9rf opened this issue Sep 29, 2023 · 0 comments · Fixed by #3833

Comments

@ab9rf
Copy link
Member

ab9rf commented Sep 29, 2023

50.10 added a std::function hook to call translate_name, in light of #3820 we should probably figure out how to use this because it appears our code for this is possibly out of date

the value of the published global translate_name is of type std::function<void(namest*, string&, char, char)> where namest is bay12's name for what we call language_name. we can probably use this with a reinterpret_cast<std::function<std::function<void(namest*, string&, bool, bool)> >(df::global::translate_name)->(name,string,false,false) but that needs to be tested

@ab9rf ab9rf linked a pull request Sep 30, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant