EventManager/Eventful - Generate event arrays

[cppcooper]

A PR for just the auto-generated arrays part so we can avoid manual synchronization and sneaky problems arising.

[myk002]

legitimate build error on windows:
library/modules/EventManager.cpp(186): error C2027: use of undefined type 'std::array<eventManager_t,16>'

[cppcooper]

Oops. I forgot the include

[myk002]

Overall, looks good. Have you sanity checked that appropriate events get triggered with devel/eventful-client?

Edit: it occurs to me that eventful-client should really be dumping the args that get passed to the handlers. I'll get that in when I get the chance

[cppcooper]

appropriate events get triggered with devel/eventful-client

I checked a JOB_INITIATED event 🤷 and that's what it said in the console. But also I'm not sure how it would trigger the wrong events based on how the array is built. It iterates the enum, then uses a switch to pick the function corresponding to that enum value so I'd have to type the wrong function in the switch for the wrong events to be triggered.

[myk002]

so I'd have to type the wrong function in the switch for the wrong events to be triggered.

A good rule to program by: code that isn't tested is broken. Just because it looks obviously right doesn't mean that it is. Always challenge your assumptions. No one person can understand everything in a complex system, and DF (and DFHack) is a complex system. Corner cases can surprise you.

[myk002]

I'm not sure if you have a usual process for this already, but I've found that the best way to continue development after splitting off some code like this is to create a diff patch between your dev branches and then apply the diff to a new branch off develop once the split-off code is merged. E.g:

git diff fix-2301 generate-event-arrays >/tmp/em.diff
git checkout develop; git fetch upstream; git merge upstream/develop
git checkout -b new-EventManager
git apply /tmp/em.diff

[cppcooper]

I'm not sure if you have a usual process for this already, but I've found that the best way to continue development after splitting off some code like this is to create a diff patch between your dev branches and then apply the diff to a new branch off develop once the split-off code is merged. E.g:

git diff fix-2301 generate-event-arrays >/tmp/em.diff
git checkout develop; git fetch upstream; git merge upstream/develop
git checkout -b new-EventManager
git apply /tmp/em.diff

What's wrong with merge? or rebase

[myk002]

If that works, great. I find it gives me a lot of merge conflicts when I do it that way. Creating a diff and repatching allows you to only care about what the text looks like and not have to care about the commit chain that got it there.