Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the needs_porting folder #237

Merged

Conversation

PeridexisErrant
Copy link
Contributor

There was a lot of stuff in there that had already been replaced or was obsolete; I added a notes text file and the working but unfinished replacement for dfstatus.

The new dfstatus script needs some work on magic numbers before it moves
to the scripts folder; the notes file contains my notes on further
things to delete.
went through `blame` and `history` to work out value of remaining stuff,
formatted notes for other people to read and deleted a few more plugins
replaced magic numbers in dfstatus script with `df.item_type.TOKEN`;
added dfstatus to readme and init_example; myself to contributors list,
updated needs_porting notes and removed script
all indents now use a uniform eight spaces; fixed from mix of four
spaces and tabs
to four-space indentations.  I should have read the documentation
earlier...
@angavrilov angavrilov merged commit 8a488ec into DFHack:develop May 12, 2014
@PeridexisErrant PeridexisErrant deleted the clean-up-the-needs_porting-folder branch May 15, 2014 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants