Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickfort place #168

Merged
merged 11 commits into from
Aug 1, 2020
Merged

Quickfort place #168

merged 11 commits into from
Aug 1, 2020

Conversation

myk002
Copy link
Member

@myk002 myk002 commented Jul 31, 2020

DFHack/dfhack#499 Implement stockpile placing logic for the quickfort script

Enforces the same restrictions and behavior as performing the actions from the UI

This PR does not implement stockpile setting initialization. That will take some refactoring of the current stockpile plugin logic into a stockpile module. I'll address that later.

Copy link
Member

@lethosor lethosor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross-linking the forum post for reference. Looks good!

I assume you have test blueprints of some sort locally? No rush to get those up, but it would be nice to have some to play around/test with eventually. I mostly just looked through the code here.

@myk002
Copy link
Member Author

myk002 commented Aug 1, 2020

re:test blueprints -- I haven't created a formal suite yet. I did a bunch of manual one-offs to test in different terrain and boundary conditions. Once the structure of the code settles down and basic functionality is complete, I plan to put together unit tests that exercise all the conditions. Once we start adding advanced features, I really want to have a regression testing suite in place to make sure nothing gets broken.

In the meantime, I have a sample blueprint up at https://docs.google.com/spreadsheets/d/1KcNFC63m-iHLPPdttosR5cuNiZ0vUtxlT51T_MV0588/edit#gid=706490003
just download the sheets in .csv format and quickfort run them.

Thank you for all these code reviews, by the way. I know this is a huge amount of code very quickly, and I appreciate the feedback that you give.

@myk002
Copy link
Member Author

myk002 commented Aug 1, 2020

BTW, I left stockpile settings initialization as a TODO. I'll come back to that after I refactor parts of the current stockpile plugin logic into a stockpile module.

@lethosor
Copy link
Member

lethosor commented Aug 1, 2020

That seems to work, thanks! (I didn't notice the 18; 18 starting coordinates at first, but once I accounted for that, it matched the layout.)
Understood about the stockpile handling, no worries

@lethosor lethosor merged commit b7ff25d into DFHack:quickfort Aug 1, 2020
@myk002 myk002 deleted the quickfort_place branch August 1, 2020 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants