Port loyaltycascade from Ruby to Lua #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
myk002
reviewed
Jan 18, 2023
Comment on lines
+89
to
+92
| if cache.next_slot > status_slot then | ||
| cache.next_slot = status_slot | ||
| end |
There was a problem hiding this comment.
what if there were status slots taken above status_slot? does everything need to be moved down by one?
There was a problem hiding this comment.
Honestly I'm unsure, this is a 1:1 from the ruby script and testing is difficult without an actual cascade happening. Let me know what your gut says here.
There was a problem hiding this comment.
I'd say add a comment noting the possibility so we have a place to look if things go wonky. I can do this post merge.
|
oh, also is there a loyaltycascade.rb file to delete? |
vallode
force-pushed
the
loyaltycascade-lua
branch
from
9038fa9
to
3753e47
Compare
myk002
approved these changes
Jan 24, 2023
Comment on lines
+89
to
+92
| if cache.next_slot > status_slot then | ||
| cache.next_slot = status_slot | ||
| end |
There was a problem hiding this comment.
I'd say add a comment noting the possibility so we have a place to look if things go wonky. I can do this post merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to be tested before merging, would be great to find a v50.05 compatible save suffering from a loyalty cascade.
Once merged should be ticked off in DFHack/dfhack#2081