New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn down ruby support #2081
Comments
It's not supposed to. libruby is the only one I can think of - we try to provide a build that should work for everyone, but it isn't always possible. It doesn't work out of the box on some uncommon Linux situations and new versions of macOS: #1742, #1718 Edit: I see #2023 as well. Missed those replies. I guess this falls under "uncommon Linux situations"? |
We'll need a deprecation plan to inform users that ruby is going away and give them time to rewrite any personal ruby scripts. How about we do this in stages, one stage per release:
|
Removed I think |
Ha, I should have read this before I did that last port. We can choose to merge that PR (or not) and make |
I guess what I really should have decided on is "not Ruby". It's pretty safe to rely on Lua being available - much more so than Ruby. String manipulation is also a bit easier/safer in Lua, as I'm sure you've found with argument parsing. Really the only risk I see is that people can edit/delete multicmd.lua, but it's not essential enough in my book that we should rewrite it. |
There are some that could certainly use your expertise:
|
Looking at startdwarf now. Not a one-to-one API change, apparently |
huh... i was sure that there was startdwarf in lua already... Edit; seems that i failed to port it from an old many-in-one tool |
I'm looking at |
DFHack/dfhack#2081 * Add tests for startdwarf * Use mock.observe_func() to verify that patchMemory() has the intended effect * Clarify docs and consolidate argument validation
Port locate-ore for DFHack/dfhack#2081
I guess I'll claim stripcaged.rb as I might be halfway finished now. If anyone else has started it as well or wants to, contact me in the discord and we can share notes. |
Claiming EDIT: DFHack/scripts#531 |
Lever is at DFHack/scripts#515 |
also I think this has been broken indefinitely because the item part of the ruby script doesn't seem like it would have worked ever as doors are items and would have shown in the tile being searched part of efforts for DFHack/dfhack#2081
Includes some squashed changes based on feedback received.
Includes some squashed changes based on feedback received.
I took |
|
I will tackle starvingdead.rb ported over at DFHack/scripts#537 |
Port stripcaged for DFHack/dfhack#2081
Revert "Port stripcaged for DFHack/dfhack#2081"
Includes some squashed changes based on feedback received.
Revert "Revert "Port stripcaged for DFHack/dfhack#2081""
If you intend to port a script, please make a comment on this bug to "claim" it so others don't start working on it too.
startdwarf
: migrate from Ruby to Lua scripts#385The text was updated successfully, but these errors were encountered: