Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifies the use of __slots__ for get_fields_and_field_types method #64

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

Voldivh
Copy link

@Voldivh Voldivh commented Apr 5, 2023

Summary

The attribute __slots__ from a message represents all the attributes from the python class for that message, not only the field names of each component from the message structure. So far, this shouldn't impose any issue, however, taking into account the upcoming modifications from this PR in the rosidl_python package, the current use of the attribute in the message_converter.py file would be affected and therefore, break something.

This PR solves that issue by modifying the use of __slots__ for the appropriate method to retrieve the field names and types get_fields_and_field_types().

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
@mintar mintar merged commit 0f86224 into DFKI-NI:rolling Apr 13, 2023
@mintar
Copy link
Member

mintar commented Apr 13, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants