Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NumberTraits doesn't work with (unsigned) long long int types #1396

Closed
rolanddenis opened this issue Feb 21, 2019 · 6 comments
Closed

NumberTraits doesn't work with (unsigned) long long int types #1396

rolanddenis opened this issue Feb 21, 2019 · 6 comments
Labels
Kernel

Comments

@rolanddenis
Copy link
Member

For example, SignedVersion and UnsignedVersion return wrong types with, respectively, unsigned long long and signed long long types. CInteger also fails with those types.

Related to #146 but those types are now in the standard (C++11).

Additionally, the digits values for floating-point types are wrong : it returns the number of decimal digits (e.g. FLT_DG) instead of the binary digits (e.g. FLT_MANT_DIG).
@rolanddenis
Copy link
Member Author

Moreover, shouldn't BigInteger be unbounded?

@dcoeurjo
Copy link
Member

( Impressive, an #1396 issue citing a 7 year old #146 one;) )

@dcoeurjo
Copy link
Member

BigInteger should be unbounded... indeed

@rolanddenis
Copy link
Member Author

Thanks to the "Related issues" beta feature of GitHub 😅

@rolanddenis rolanddenis mentioned this issue Feb 22, 2019
Merged
5 tasks
@dcoeurjo
Copy link
Member

We should close this one, shouldn't we ?

@rolanddenis
Copy link
Member Author

Yep, fixed in #1397 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Kernel
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dcoeurjo @rolanddenis