TableReader add #1260
Merged
TableReader add #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dcoeurjo or @JacquesOlivierLachaud can we merge ? (small PR ;) but i use in other remote) ;) |
dcoeurjo
reviewed
Apr 15, 2017
| @@ -113,7 +113,31 @@ namespace DGtal | |||
| getColumnElementsFromInputStream (std::istream &in, | |||
| unsigned int aPosition); | |||
|
|
|||
| /** | |||
| * Method to import a vector where each element contains the line | |||
| * elements of a given file. Blank line or line beginning with | |||
There was a problem hiding this comment.
how "elements" are defined ? are they "space", "comma", "tab",.. separated values ?
There was a problem hiding this comment.
space or tab I add it (and I add tabs in the test file pointList1.pl
There was a problem hiding this comment.
don't remember the original TableReader PR :/
|
;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Just to add the possibility to read the all the lines contents in input file.
Checklist
cmakemode (otherwise, Travis C.I. will fail).