Fixing #1296 : invalid cell coordinates in ctopo-fillContours.cpp #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See DGtal-team#1296. The KhalimskyCell is only used to get his className in order to define a CustomStyle for the Board2D. The fix replaces the invalid cell by the lowerCell of the KhalismkySpace.
|
thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The invalid
KhalimskyCellis only used to get hisclassNamein order to define aCustomStylefor theBoard2D. This fix replaces the invalid cell by thelowerCellof theKhalimskySpace.I'm wondering if
lowerCellmethods shouldn’t bestaticinstead ?See #1296
Checklist
[ ] Unit-test of your feature with Catch.[ ] Doxygen documentation of the code completed (classes, methods, types, members...)[ ] Documentation module page added or updated.cmakemode (otherwise, Travis C.I. will fail).