Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change float for double type in the switch case #1322

Merged
merged 2 commits into from
Jun 17, 2018
Merged

Change float for double type in the switch case #1322

merged 2 commits into from
Jun 17, 2018

Conversation

akrah
Copy link
Contributor

@akrah akrah commented May 25, 2018 •
edited
Loading

PR Description

Probably a bad copy/past in the switch case with all ITK defined types.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

@dcoeurjo
Copy link
Member

Beside gcc issues on travis, this Pr looks good.
Can you please update the Changelog ?

@dcoeurjo dcoeurjo added this to the 1.0 milestone May 30, 2018
@akrah
Copy link
Contributor Author

akrah commented May 30, 2018

ChangeLog updated.
Travis compilations fail in three cases, due to "trackImplicitPolynomialSurfaceToOFF.cpp" that I didn't changed, a download error of gcc and a compilation time limit.
I suppose that all is ok ?

@dcoeurjo
Copy link
Member

All good.. thanks.

@dcoeurjo dcoeurjo merged commit 1ef1349 into DGtal-team:master Jun 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akrah @dcoeurjo