-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two new star shapes #1325
Two new star shapes #1325
Conversation
Thanks @akrah |
Two questions: |
Please merge the master to this branch yourself (and fix the possible conflicts;)). |
thx for the PR BTW |
Merge conflicts done. |
It looks like you’ve only added your name to the package, the module is missing. Thx |
- Bug fix in Lemniscate and Astroid about the declaration of Point2D - Add figure of Lemniscate and Astroid in moduleShape.dox - Delete double entries in moduleShape.dox - Add new example in doc: exampleParametricShapes.cpp
Right, sorry, I didn't see the file moduleShape.dox. |
Thanks. It looks like there is an issue while generating the doc. Could you please have a look ? |
@dcoeurjo All seems ok ,it was a just a typo in a path. |
perfect.thx |
Merging |
PR Description
We propose two new star shapes: Astroid and Lemniscate.
Checklist
cmake
mode (otherwise, Travis C.I. will fail).