Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DGtal for dummies #1357

Merged
merged 120 commits into from
Nov 17, 2018
Merged

Conversation

JacquesOlivierLachaud
Copy link
Member

@JacquesOlivierLachaud JacquesOlivierLachaud commented Nov 4, 2018

PR Description

This PR provides helper functions to simplify the code for a DGtal user. It includes for now functions for manipulating images, digital surfaces, triangulated and polygonal surfaces, mesh, getting true geometry, estimating geometry, exporting as OBJ, etc.
It is essentially focused on 3D geometry processing, but 2D support could be added in a similar spirit.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

dcoeurjo and others added 11 commits November 13, 2018 11:56
Co-Authored-By: JacquesOlivierLachaud <jacques-olivier.lachaud@univ-savoie.fr>
Co-Authored-By: JacquesOlivierLachaud <jacques-olivier.lachaud@univ-savoie.fr>
Co-Authored-By: JacquesOlivierLachaud <jacques-olivier.lachaud@univ-savoie.fr>
Co-Authored-By: JacquesOlivierLachaud <jacques-olivier.lachaud@univ-savoie.fr>
Co-Authored-By: JacquesOlivierLachaud <jacques-olivier.lachaud@univ-savoie.fr>
Co-Authored-By: JacquesOlivierLachaud <jacques-olivier.lachaud@univ-savoie.fr>
Co-Authored-By: JacquesOlivierLachaud <jacques-olivier.lachaud@univ-savoie.fr>
Co-Authored-By: JacquesOlivierLachaud <jacques-olivier.lachaud@univ-savoie.fr>
Co-Authored-By: JacquesOlivierLachaud <jacques-olivier.lachaud@univ-savoie.fr>
Co-Authored-By: JacquesOlivierLachaud <jacques-olivier.lachaud@univ-savoie.fr>
Co-Authored-By: JacquesOlivierLachaud <jacques-olivier.lachaud@univ-savoie.fr>
@JacquesOlivierLachaud
Copy link
Member Author

Should be ok now.

Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the edits.. few comments on the remaining files. I'm done know. congrats.

src/DGtal/shapes/MeshHelpers.h Outdated Show resolved Hide resolved
src/DGtal/shapes/MeshHelpers.h Show resolved Hide resolved
src/DGtal/shapes/MeshHelpers.ih Show resolved Hide resolved
src/DGtal/shapes/parametric/AccFlower2D.h Show resolved Hide resolved
@dcoeurjo
Copy link
Member

All good:)
Thx

Merging this PR

@dcoeurjo dcoeurjo merged commit b911c6a into DGtal-team:master Nov 17, 2018
- \ref PolygonalSurface: use MeshHelpers::exportOBJ, and MeshHelpers::exportOBJwithFaceNormalAndColor
- Mesh: use MeshWriter::export2OBJ
- TriangulatedSurface: use MeshHelpers::exportOBJ, and MeshHelpers::exportOBJwithFaceNormalAndColor
- PolygonalSurface: use MeshHelpers::exportOBJ, and MeshHelpers::exportOBJwithFaceNormalAndColor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a little bit too late, but you can still use ref by specifying an empty string as second parameter:

    - \ref Mesh "": use MeshWriter::export2OBJ

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why it was not working. It seems \ref was perturbed by the ':' afterwards. Thanks for the trick !

@JacquesOlivierLachaud JacquesOlivierLachaud deleted the DGtalForDummies branch November 19, 2018 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants